Remove default namespace from being selected by fargate, also adds secgrouppolicies for essentials namespace along with kube-system namespace #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niroz89
reviewed
Jun 22, 2023
fargate_profile.tf
Outdated
| @@ -54,6 +43,7 @@ module "fargate_profiles" { | |||
| fargate_profile_defaults = var.fargate_profile_defaults | |||
| create_aws_observability_ns = var.create_aws_observability_ns | |||
| create_fargate_logger_configmap = var.create_fargate_logger_configmap | |||
| eks_worker_security_group_id = module.eks.node_security_group_id | |||
There was a problem hiding this comment.
@thepoppingone no need to pass fargate_namespaces_for_security_group for creating security group policies for kube-system ns ?
There was a problem hiding this comment.
ah i realized what you meant now
uchinda-sph
approved these changes
Jun 23, 2023
thepoppingone
changed the title
thepoppingone
force-pushed
the
remove-default-ns-fargate
branch
from
79b10c4
to
3304825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.